Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --pipeline=/path/to/pipeline.yaml with a "direct router" #134

Open
markmc opened this issue Jul 15, 2024 · 3 comments
Open

Support --pipeline=/path/to/pipeline.yaml with a "direct router" #134

markmc opened this issue Jul 15, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@markmc
Copy link
Contributor

markmc commented Jul 15, 2024

Currently --pipeline takes an alias or a directory, resolving to a directory containing knowledge.yaml, grounded_skills.yaml, and freeform_skills.yaml and the appropriate pipeline is chosen based on the data provided (aka "taxonomy routing"

There is a use case where, during experimentation, the user may want to run a specific pipeline directly

See instructlab/dev-docs#109 (comment) where we discussed a "router" design for this use case

This would allow ilab data generate support the starting point for data generation tasks use case described in aakankshaduggal@61eff48 rather adding a new entrypoint

@markmc markmc added this to the 0.1.3 milestone Jul 15, 2024
@markmc markmc modified the milestones: 0.1.3, 0.2.0 Jul 19, 2024
@markmc markmc modified the milestones: 0.2.0, 0.2.1 Jul 23, 2024
@nathan-weinberg nathan-weinberg added the enhancement New feature or request label Aug 20, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions bot added the stale label Nov 22, 2024
@bbrowning
Copy link
Contributor

We will want to support directly specifying the pipeline to run (as opposed to a folder). Keeping this from going stale.

@bbrowning bbrowning removed the stale label Dec 2, 2024
jwm4 pushed a commit to jwm4/sdg that referenced this issue Dec 13, 2024
…_actions/step-security/harden-runner-2.10.1

Bump step-security/harden-runner from 2.9.1 to 2.10.1
@bbrowning
Copy link
Contributor

We will expose an API to run a single pipeline, and likely a CLI within SDG itself to do the same. However, that does not mean we'll necessarily do an ilab data generate --pipeline=/path/to/pipeline.yaml as that discussion would take place in the instructlab/instructlab repository once we have an API to run a single pipeline within SDG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants