[Feature Request]: Include transformators to the tm_ modules
#1441
Assignees
Labels
Comments
m7pr
added a commit
that referenced
this issue
Jan 15, 2025
Part of #1441 A reviewed documentation for `transformators` parameter --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
|
@m7pr why not apply to |
|
@gogonzo I will, once we get this conversation sorted out insightsengineering/teal.modules.general#826 (comment) |
|
|
m7pr
added a commit
to insightsengineering/teal.modules.general
that referenced
this issue
Jan 20, 2025
insightsengineering/teal#1441 Included `transformators` parameter in modules. This is passed to `teal::module` that does assertions and checks on this parameter. Did not introduce for `tm_data_table`, `tm_file_viewer` and `tm_front_page` as we also didn't introduce `decorators` for those modules. We can always introduce, if there is a user request, but I don't think there will ever be. Lastly, a food for thought: default `decorators` value is `NULL` where default `transformators` value is `list()`. Maybe we can introduce a check, that allows `transformators` to be `NULL` on default, and which changes `NULL` to `list()`. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lluís Revilla <[email protected]>
This was referenced Jan 21, 2025
m7pr
added a commit
to insightsengineering/teal.goshawk
that referenced
this issue
Jan 21, 2025
insightsengineering/teal#1441 Included `transformators` parameter in modules. This is passed to `teal::module` that does assertions and checks on this parameter. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
m7pr
added a commit
to insightsengineering/teal.osprey
that referenced
this issue
Jan 21, 2025
insightsengineering/teal#1441 Included `transformators` parameter in modules. This is passed to `teal::module` that does assertions and checks on this parameter. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
m7pr
added a commit
to insightsengineering/teal.modules.clinical
that referenced
this issue
Jan 22, 2025
insightsengineering/teal#1441 Included `transformators` parameter in modules. This is passed to `teal::module` that does assertions and checks on this parameter. A food for thought: default `decorators` value is `NULL` where default `transformators` value is `list()`. Maybe we can introduce a check, that allows `transformators` to be `NULL` on default, and which changes `NULL` to `list()`. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature description
Should be a simple fix:
tm_*formals bytransformators = list()transformatorsargument value tomodule(..., transformators = transformators).Code of Conduct
Contribution Guidelines
Security Policy
The text was updated successfully, but these errors were encountered: