Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Display dataset labels not names in Encoding and Filter panel #594

Open
3 tasks done
thomas-neitmann opened this issue Aug 17, 2023 · 3 comments
Open
3 tasks done
Labels
core enhancement New feature or request

Comments

@thomas-neitmann
Copy link

thomas-neitmann commented Aug 17, 2023

Feature description

I'd like the label of a dataset rather than its name (e.g. "Adverse Events" rather than "ADAE") to be displayed in the encodings and filter panel. While there is a label parameter in the cdisc_dataset() function setting it does not have the desired effect. Right now I'm abusing the name parameter for this purpose (see example below) but this does not work for ADSL and also the name cannot contain spaces.

cdisc_dataset(
  "AdverseEvents",
  adae,
  keys = get_cdisc_keys("ADAE"),
  code = paste(deparse(adae_code), collapse = "\n")
)
image
image

Code of Conduct

  • I agree to follow this project's Code of Conduct.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines.

Security Policy

  • I agree to follow this project's Security Policy.
@thomas-neitmann thomas-neitmann added the enhancement New feature or request label Aug 17, 2023
@lcd2yyz lcd2yyz added the core label Aug 18, 2023
@lcd2yyz
Copy link

lcd2yyz commented Oct 13, 2023

Is this something we can tackle along with teal.data refactor? @gogonzo @donyunardi

@donyunardi
Copy link
Contributor

Let's put this on backlog.
We'll come back once we're done with refactor.

@gogonzo gogonzo transferred this issue from insightsengineering/teal May 24, 2024
@gogonzo
Copy link
Contributor

gogonzo commented May 24, 2024

Acceptance criteria: implement displaying "label" in the filter-panel as oppose to binding name

Currently to assign label to object in teal_data one has to add attribute to the binding. However this has no effect in filter-panel and anywhere futher.

teal_data() |> within({

  IRIS <- iris
  attr(IRIS, "label") <- "Edgar Anderson's Iris Data"
})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants