diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index e1bf66405..6a3ca9af4 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -8,15 +8,6 @@ on: workflow_dispatch: jobs: - build: - name: Build package 🎁 - needs: release - uses: insightsengineering/r.pkg.template/.github/workflows/build-check-install.yaml@main - secrets: - REPO_GITHUB_TOKEN: ${{ secrets.REPO_GITHUB_TOKEN }} - with: - skip-r-cmd-check: true - skip-r-cmd-install: true docs: name: Pkgdown Docs 📚 needs: release @@ -53,6 +44,7 @@ jobs: checking examples .* NOTE checking Rd line widths .* NOTE checking top-level files .* NOTE + skip-r-cmd-install: true coverage: name: Coverage 📔 needs: [release, docs] diff --git a/cran-comments.md b/cran-comments.md index f381ea67d..f34110a39 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -14,10 +14,13 @@ ## Additional Comments -* This is a new release. +* This is a re-submission of a new release. +* Thank you for the review comments. + - Unexported functions no longer have examples. + - The `installed.packages()` function has been removed/replaced. + - References to software names and APIs in the DESCRIPTION have been removed to highlight other package functionality, therefore, no need to quote them. + * There are no additional references describing the methods in this package. -* I have created documentation Rd files for many non-exported functions and included examples for these unexported functions. This is a collaborative project, and the documentation is incredibly helpful to on-board new collaborators and help them understand the internal workings of the package. I've read through the R Packages manual and I do not believe there is a specific rule against this, but have heard reports of comments requesting that they are removed. If I can keep the documentation as it is, I would be much appreciative. Thank you! - * Thank you for your time! diff --git a/inst/WORDLIST b/inst/WORDLIST index c42283059..6fd4febc6 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -35,6 +35,3 @@ tidyselect tidyselector tidyselectors univariable -unlist -unnested -unnests