Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.equals() methods of RealTransformUnaryCompositeRealMaskRealInterval behaves strange #69

Open
tischi opened this issue Oct 21, 2023 · 2 comments
Labels

Comments

@tischi
Copy link
Contributor

tischi commented Oct 21, 2023

@tpietzsch @bogovicj

Within the class RealTransformUnaryCompositeRealMaskRealInterval I found this issue:

image

As you can see in the lower part of the screenshot this and obj are in fact the same Java objects. Nevertheless the .equals() method returns false.

Is this a bug or could it be an error on my side?

@tpietzsch
Copy link
Member

This is a bug, definitely. Not on your side.

@tpietzsch
Copy link
Member

tpietzsch commented Oct 23, 2023

I think to fix it, it would be good to go through all the .equals() methods in this package and look at what they are actually supposed to do... Does the javadoc already say something about the intented behaviour? Then maybe find the
"top-most" interfaces regarding intented behaviour (CompositeMaskPredicate? UnaryCompositeMaskPredicate?) and add static equals methods there that can be called from the implementations?

@tpietzsch tpietzsch added the bug label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants