Ad campaign total score ranking issue

[QuickMythril]

Describe the bug
Ads are not displaying properly ranked by total score. Lower score ads are being displayed before higher ones.

Module

• Ads

To Reproduce
Steps to reproduce the behavior:

1. When the highest score (Ad 1) is a specific language with 22x, and the second highest (Ad 2) is any language with 1x.
2. Burn for your own campaign (Ad 3) in any language with 1x, to be the third highest score, lower than Ad 2.
3. Burn for your own campaign (Ad 4) in a specific language with 22x, to be the second highest score, lower than Ad 1, higher than Ad 2.
4. The "All Offers" page will show ads in the order 1, 4, 2, 3. The advertisements being displayed will be in the order 1, 2, 3.

Expected behavior
It's expected that the three ads with highest total score are shown in order, in this case 1, 4, 2.

Identity context

• Human
• 0x6118b2fcb8075a54b3ef3f02c4d7aa5a5c513afb

Idena Client logs
N/A

Screenshots / Screencasts

Environment:

• OS: Qubes OS / Kicksecure 16 / Debian 11
• Node mode: built-in
• Client version 0.39.1
• Node version 1.1.1

Additional context
Here is my specific example, since the above explanation may not be clear.

1: burn 3.0000 x 22 = 66.0000 (EN only)
2: burn 2.9500 x 22 = 64.9000 (RU only)
3: burn 0.5002 x 22 = 11.0044 (EN only) - my ad # 1 in EN
4: burn 0.5002 x 22 = 11.0044 (RU only) - my ad # 1 in RU
5: burn 0.5001 x 22 = 11.0022 (EN only) - my ad # 2 in EN
6: burn 0.5001 x 22 = 11.0022 (RU only) - my ad # 2 in RU
7: burn 2.0000 x 1 = 2.0000 (Any)
8: burn 1.0000 x 1 = 1.0000 (Any)
9: burn 1.0000 x 1 = 1.0000 (Any)
10: burn 0.8002 x 1 = 0.8002 (Any) - my ad # 1 in Any
11: burn 0.8001 x 1 = 0.8001 (Any) - my ad # 2 in Any

i have two ads (# 1 and # 2) and they have three campaigns for each (EN, RU, Any).

when i set my settings to EN:
i see ads: 1, 7, 8
it should be 1, 3, 5.

when i set my settings to RU:
i see ads: 2, 7, 8
it should be 2, 4, 6.

currently there are no other language specifc ads (only EN and RU)
when i set my settings to Any other language:
i see ads: 7, 8, 9 as expected.

it seems like my "duplicated" campaigns (3, 4, 5, 6) are being ignored.
it's only counting the scores for the lower ones (10 and 11).

--Additional Testing--
i thought this is because 10/11 are higher burn (0.8 IDNA) and 3-6 are lower (0.5 IDNA)
however i tested by burning more for ad 4 (RU) so it was higher than 10 (Any).
still i was shown 2, 7, 8 and my ad 4 was not displayed, despite being higher total score.

[QuickMythril]

Here it is happening again:

When set to English, the 11 and 6 IDNA ads are first, ignoring the ones with 11.24 (the most).

When set to Russian, the 7.26 and 6 IDNA ads are first, ignoring the ones with 7.50 (the most).

When set to another language (French for example), the ads are working as expected.
I think this is due to multiple instances of the same campaign interfering with the scoring.

[QuickMythril]

this continues to be an issue with the ad system. i think this is quite unacceptable for something that takes your money, and doesn't apply it as intended. if the wallet was randomly sending to the wrong address 10% of the time that would be a serious problem. please i would request a higher prioritization of this issue. if we need to raise some funds to help get that accomplished please let me know. i want to see this platform functional and successful and if one of the major use cases is not working properly, that reflects badly on every other part of it.

[QuickMythril]

i would also like to add to this report, as i am currently experiencing this issue again, but cannot resolve it in the usual way. right now i have THREE instances of the same ad campaign burned.

Any/Any (9.91 x 1) = 9.91
Eng/Any (9.89 x 22) = 217.58
Eng/Win (9.87 x 110) = 1085.70

however when on a linux system set to english, i am seeing THREE OTHER ads, that ALL have less score than ALL my ads.
1st = (7.88 x 22) = 173.356
2nd = (6.41 x 22) = 141.02
3rd = (6.00 x 22) = 132.00
N/A = (9.89 x 22) = 217.58 (mine)

[aidenaio]

Thanks for the heads up! The issue is quite complicated. We'll figure it out.