Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine store asset transfers #4782

Closed
nxsaken opened this issue Jun 27, 2024 · 2 comments
Closed

Refine store asset transfers #4782

nxsaken opened this issue Jun 27, 2024 · 2 comments
Assignees
Labels
api-changes Changes in the API for client libraries question Further information is requested

Comments

@nxsaken
Copy link
Contributor

nxsaken commented Jun 27, 2024

Currently, transferring a store asset removes the whole asset from the source account, and tries to insert it into the target account, with no effect if the target account already has an asset of that definition. This is surprising: I would expect the target asset to be replaced or merged with the source.

Because two store assets of the same definition could have different KV-pairs, I think Transfer(Store, Source, Target) should result in a merge of the two assets, with the source key-value pairs replacing those in the target, while leaving other key-value pairs in the target alone. The KV-pairs supported by a store asset could be part of the asset definition to avoid this altogether.

Alternatively, we could introduce a separate Transfer(Store, Key, Source, Target) instruction that only transfers a single key-value pair from the source asset to the destination.

@nxsaken nxsaken added question Further information is requested api-changes Changes in the API for client libraries labels Jun 27, 2024
@nxsaken
Copy link
Contributor Author

nxsaken commented Jun 28, 2024

Related: #4353 (comment)

@mversic
Copy link
Contributor

mversic commented Aug 9, 2024

closing in favor of #4087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes Changes in the API for client libraries question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants