Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the use of hashes and rng when generating keys from seeds #4190

Closed
DCNick3 opened this issue Jan 10, 2024 · 1 comment
Closed

Investigate the use of hashes and rng when generating keys from seeds #4190

DCNick3 opened this issue Jan 10, 2024 · 1 comment
Assignees
@Arjentix @timofeevmd
Labels
crypto Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@DCNick3
Copy link
Contributor

DCNick3 commented Jan 10, 2024

Originally raised here.

For Ed25519Sha512 the seed is first hashed and then fed into ChaChaRng to generate the key. Here the order is reversed. Fishy stuff...

We should determine a proper consistent way to do this and ensure that all signature algorithms do this we had a tool for that it was called functions.

Or maybe remove the key generation from a seed altogether if iroha doesn't use it.
@DCNick3 DCNick3 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST crypto labels Jan 10, 2024
@DCNick3 DCNick3 mentioned this issue Jan 10, 2024
Merged
5 tasks
@Arjentix Arjentix self-assigned this Feb 15, 2024
Arjentix added a commit to Arjentix/iroha that referenced this issue Feb 16, 2024
@Arjentix
[fix] hyperledger-iroha#4190: Fix seed-based keys generation
7329ae7 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix Arjentix mentioned this issue Feb 16, 2024
Merged
5 tasks
mversic pushed a commit that referenced this issue Feb 17, 2024
@Arjentix
[fix] #4190: Fix seed-based keys generation (#4286)
fbdd591 
Signed-off-by: Daniil Polyakov <[email protected]>
@Arjentix
Copy link
Contributor

For test I suggest to try seed less than 32 bytes for secp256k1 algorithm. Previosly it was an error, now it should be fine

@timofeevmd timofeevmd self-assigned this Feb 20, 2024
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

@timofeevmd timofeevmd

Labels
crypto Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DCNick3 @Arjentix @timofeevmd