Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wrong code highlighting for some Data Table component plugins #996

Closed
meeusnietmeus opened this issue Apr 6, 2024 · 2 comments · Fixed by #1004
Closed

docs: wrong code highlighting for some Data Table component plugins #996

meeusnietmeus opened this issue Apr 6, 2024 · 2 comments · Fixed by #1004
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation

Comments

@meeusnietmeus
Copy link
Contributor

Change Type

Cleanup (formatting, typos, etc.)

Proposed Changes

On the data table section under 'components', there is wrong code highlighting for enabling the addHiddenColumns plugin.
The pagination plugin and some closing brackets are highlighted instead.

image

This is true for Row Selection as well.
image

@meeusnietmeus meeusnietmeus added the type: documentation A change or addition to the documentation label Apr 6, 2024
@huntabyte huntabyte added the status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation label Apr 7, 2024
@meeusnietmeus
Copy link
Contributor Author

meeusnietmeus commented Apr 8, 2024

I see the issue is marked for help. I could fix it maybe? Isn't a lot of work.


By the way i also noticed some inconsistency among the example code, for example:

It says to import <Checkbox />, but in the code DataTableCheckbox is imported.
image

The disabling of sorting for this column is gone here, whilst it was there for the 'visibility' section of the page.
image

@huntabyte
Copy link
Owner

PRs welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants