Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical orientation for tabs #960

Closed
martinjo opened this issue Mar 27, 2024 · 5 comments
Closed

Vertical orientation for tabs #960

martinjo opened this issue Mar 27, 2024 · 5 comments
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation

Comments

@martinjo
Copy link

Describe the feature

Tabs have a ”orientation” property that I was expecting to affect how the tabs orient themselves visually. It seems to have no or another effect. But having an orientation property that affects layout (horizontal/vertical) would be so nice.

Are there any plans for this or examples of how it could be achieved?

@martinjo martinjo added the type: feature Introduction of new functionality to the application label Mar 27, 2024
@huntabyte
Copy link
Owner

The orientation is for accessibility purposes. We could possibly add an example for vertical tabs.

@martinjo
Copy link
Author

I figured it had some function :). An example with vertical tabs would be great! 🙏

@huntabyte huntabyte added type: documentation A change or addition to the documentation status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation and removed type: feature Introduction of new functionality to the application labels Apr 1, 2024
@BeGeos
Copy link

BeGeos commented Apr 9, 2024

What would the example need to be? Like just a piece of code or a with a selectable preview also?

@oluijks
Copy link
Contributor

oluijks commented Jun 28, 2024

@huntabyte The name of the property `orientation' (The orientation of the tabs) is a bit misleading, it suggests that the tabs could be visually rendered horizontally or vertically. The documentation in the code of bits-ui is clear about this but I can imagine that people would be a little disappointed when finding out that it only applies to keyboard navigation...

What to do? Update bits-ui property name and docs or update the shadcn-svelte docs with a remark about the tabs properties? Or a third option: implement visually vertically rendered tabs?

@huntabyte
Copy link
Owner

The orientation is documented in Bits UI @next as determining keyboard navigation. If you wish to add vertical tabs to shadcn-svelte, the code is yours. You're more than welcome to add a variation to your codebase, but until it's added to the original shadcn/ui, then it won't be added here.

@huntabyte huntabyte closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted This issue is tentatively accepted pending a volunteer committed to its implementation type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

4 participants