-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical orientation for tabs #960
Comments
The orientation is for accessibility purposes. We could possibly add an example for vertical tabs. |
I figured it had some function :). An example with vertical tabs would be great! 🙏 |
What would the example need to be? Like just a piece of code or a with a selectable preview also? |
@huntabyte The name of the property `orientation' (The orientation of the tabs) is a bit misleading, it suggests that the tabs could be visually rendered horizontally or vertically. The documentation in the code of bits-ui is clear about this but I can imagine that people would be a little disappointed when finding out that it only applies to keyboard navigation... What to do? Update bits-ui property name and docs or update the shadcn-svelte docs with a remark about the tabs properties? Or a third option: implement visually vertically rendered tabs? |
The orientation is documented in Bits UI @next as determining keyboard navigation. If you wish to add vertical tabs to shadcn-svelte, the code is yours. You're more than welcome to add a variation to your codebase, but until it's added to the original shadcn/ui, then it won't be added here. |
Describe the feature
Tabs have a ”orientation” property that I was expecting to affect how the tabs orient themselves visually. It seems to have no or another effect. But having an orientation property that affects layout (horizontal/vertical) would be so nice.
Are there any plans for this or examples of how it could be achieved?
The text was updated successfully, but these errors were encountered: