-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies like bits-ui should be installed as devDependencies and not dependencies #1304
Comments
Bits UI is a production dependency, which is why it is in dependencies and not devDependencies 😃 |
If a component library isn't a production dependency/non-dev dependency then I'm not sure what would go into |
Alright after some discussion with others you are correct. I didn't consider the fact of running We'll update this once we get a chance unless someone wants to make a PR! |
🙇 Thanks Hunter, really appreciate it! |
It looks like to make this happen we would need to update the Or can we safely say everything is a dev dependency? I do have everything in my projects installed as a dev dependency with no issues using almost all of the components. |
Everything we install should be a dev dependency. |
Describe the bug
When deploying SvelteKit sites using adapter-node, whether you use dependencies or devDependencies matter. devDependencies get bundled by Rollup, while normal dependencies are left in node_modules and externalized. By default, when adding components with
npx shadcn-svelte@latest add
dependencies like bits-ui are added to dependencies when it's preferential that they be in devDependencies.https://kit.svelte.dev/docs/adapter-node#deploying
This is a follow-up on #580 which was closed because I think it was not correctly interpreted.
Reproduction
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: