Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format installed components using local prettier config #1022

Closed
H0R5E opened this issue Apr 15, 2024 · 1 comment
Closed

Format installed components using local prettier config #1022

H0R5E opened this issue Apr 15, 2024 · 1 comment
Labels
type: feature Introduction of new functionality to the application

Comments

@H0R5E
Copy link

H0R5E commented Apr 15, 2024

Hi, thanks for the amazing project, I'm really enjoying using it.

Describe the feature

I was wondering if it would be possible to format the installed component code with the local prettier configuration?

For instance, the installed components use tab indentation, whereas I have the indentation set to default (i.e. with spaces).

I think shadcn-ui#1014 is a relevant issue, but I don't know if it conforms to the local formatting config on install.

All the best,

Mat

@H0R5E H0R5E added the type: feature Introduction of new functionality to the application label Apr 15, 2024
@AdrianGonz97
Copy link
Collaborator

Thanks for the suggestion!

We used to do this, but decided to take it out as it increased the complexity of CLI for very little benefit. It's far more simple for users to just run npm run format after installing the components than it is for us to do it for them.

@AdrianGonz97 AdrianGonz97 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants