From 2394b4314e2597a55b0f75d977ace7b68fa87de3 Mon Sep 17 00:00:00 2001 From: Binyamin Aron Green Date: Thu, 15 Oct 2020 15:35:41 -0400 Subject: [PATCH 1/2] Create pull_request_template.md --- .github/pull_request_template.md | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..773b01d2d1 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,11 @@ + + + + +## Changes + + +## Checklist +- [ ] I added markup tests, or they don't apply here because... +- [ ] I updated the changelog at `CHANGES.md` +- [ ] My name is in `AUTHORS.txt`, under contributors From 91556445e02fcfbe64e5d0462753ee9219f2bfe0 Mon Sep 17 00:00:00 2001 From: Binyamin Aron Green Date: Fri, 16 Oct 2020 12:12:00 -0400 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Josh Goebel --- .github/pull_request_template.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 773b01d2d1..21245f47e6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,11 +1,12 @@ + -## Changes +### Changes -## Checklist -- [ ] I added markup tests, or they don't apply here because... -- [ ] I updated the changelog at `CHANGES.md` -- [ ] My name is in `AUTHORS.txt`, under contributors +### Checklist +- [ ] Added markup tests, or they don't apply here because... +- [ ] Updated the changelog at `CHANGES.md` +- [ ] Added myself to `AUTHORS.txt`, under Contributors