Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "Too many arguments" on methods that implement interfaces #23

Open
cmeeren opened this issue Nov 23, 2016 · 1 comment
Open

Ignore "Too many arguments" on methods that implement interfaces #23

cmeeren opened this issue Nov 23, 2016 · 1 comment

Comments

@cmeeren
Copy link

cmeeren commented Nov 23, 2016

3rd party or builtin interfaces may have methods requiring several arguments (e.g. Xamarin.Forms.IValueConverter, which defines Convert and ConvertBack with four arguments each). In these cases, CleanCode should not warn that the methods that implement the interfaces require too many arguments.

In general, I suggest that interface-implementing methods should be skipped entirely by the "too many arguments" check, and instead CleanCode should warn about this on the actual interface definitions.

@NKnusperer
Copy link

In general it would be nice to have an option to include "just my code" or to exclude the BCL / third party libraries. Fox example when implementing IList<T>.Add(T item) it raises a MethodNameNotMeaningful warning. Obviously there is nothing we can do about it except ignoring it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants