From 872df201a3438d98465cbf1b5b19ecb56fda39f3 Mon Sep 17 00:00:00 2001 From: Cody Brittain Date: Tue, 3 Sep 2024 06:45:33 -0400 Subject: [PATCH] Changed minimum IPC heights to reflect lore (#19855) Per NobleRow: ![image](https://github.com/user-attachments/assets/6812f9fd-54e7-4671-9a71-b1e2ce4076af) The extremely low values were questioned for IPCs. The old values were really small. This fixes it to lore-accurate values. --------- Co-authored-by: Cody Brittain --- .../carbon/human/species/station/ipc/ipc.dm | 2 +- .../species/station/ipc/ipc_subspecies.dm | 4 +- .../GeneralCamo - IPC Minimum Height.yml | 60 +++++++++++++++++++ 3 files changed, 64 insertions(+), 2 deletions(-) create mode 100644 html/changelogs/GeneralCamo - IPC Minimum Height.yml diff --git a/code/modules/mob/living/carbon/human/species/station/ipc/ipc.dm b/code/modules/mob/living/carbon/human/species/station/ipc/ipc.dm index 8aed2ce0e24..9a3218a1922 100644 --- a/code/modules/mob/living/carbon/human/species/station/ipc/ipc.dm +++ b/code/modules/mob/living/carbon/human/species/station/ipc/ipc.dm @@ -5,7 +5,7 @@ category_name = "Integrated Positronic Chassis" bodytype = BODYTYPE_IPC species_height = HEIGHT_CLASS_SHORT - height_min = 100 + height_min = 120 height_max = 250 age_min = 1 age_max = 60 diff --git a/code/modules/mob/living/carbon/human/species/station/ipc/ipc_subspecies.dm b/code/modules/mob/living/carbon/human/species/station/ipc/ipc_subspecies.dm index 10d6b1a84ce..9e27d2c0025 100644 --- a/code/modules/mob/living/carbon/human/species/station/ipc/ipc_subspecies.dm +++ b/code/modules/mob/living/carbon/human/species/station/ipc/ipc_subspecies.dm @@ -5,7 +5,7 @@ name_plural = "Shells" bodytype = BODYTYPE_HUMAN species_height = HEIGHT_CLASS_AVERAGE - height_min = 140 + height_min = 145 height_max = 230 default_genders = list(MALE, FEMALE) selectable_pronouns = list(MALE, FEMALE, PLURAL, NEUTER) @@ -129,6 +129,7 @@ bald = 1 bodytype = BODYTYPE_IPC_INDUSTRIAL species_height = HEIGHT_CLASS_HUGE + height_min = 180 mob_size = 12 unarmed_types = list(/datum/unarmed_attack/industrial, /datum/unarmed_attack/palm/industrial) @@ -359,6 +360,7 @@ short_name = "xmf" bodytype = BODYTYPE_IPC_INDUSTRIAL species_height = HEIGHT_CLASS_TALL + height_min = 180 icobase = 'icons/mob/human_races/ipc/r_ind_xion.dmi' deform = 'icons/mob/human_races/ipc/r_ind_xion.dmi' diff --git a/html/changelogs/GeneralCamo - IPC Minimum Height.yml b/html/changelogs/GeneralCamo - IPC Minimum Height.yml new file mode 100644 index 00000000000..a220fea0102 --- /dev/null +++ b/html/changelogs/GeneralCamo - IPC Minimum Height.yml @@ -0,0 +1,60 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: GeneralCamo + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - qol: "Changed the minimum height of baseline, bishop, and mobility IPCs from 100cm to 120cm." + - qol: "Changed the minimum height of shell IPCs from 100cm to 145cm." + - qol: "Changed the minimum height of G1, G2, and xion IPCs from 100cm to 180cm."