You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's used directly as google-protobuf/google/protobuf/wrappers_pb.js in a number of places here, but there is a problem with that -- that file has been compiled in commonjs mode instead of commonjs_strict, which brings the same issues with globals pollution and CSP incompatibility. protocolbuffers/protobuf-javascript#25 is related.
A possible solution would be to replace all direct usage of that compiled js file with a proto file inside this repo, compiled in the same mode as all the other proto files. Perhaps even a subset of that file if not all imports are used.
The text was updated successfully, but these errors were encountered:
ChALkeR
changed the title
Consider removing usage of google/protobuf/wrappers and using a in-repo protocol for that
Consider removing usage of google/protobuf/wrappers and using an in-repo protocol for that
Aug 5, 2020
Currently, this library uses one proto file not present in the repo itself:
google/protobuf/wrappers
.That protocol is completely trivial: https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/wrappers.proto
It's used directly as
google-protobuf/google/protobuf/wrappers_pb.js
in a number of places here, but there is a problem with that -- that file has been compiled incommonjs
mode instead ofcommonjs_strict
, which brings the same issues with globals pollution and CSP incompatibility. protocolbuffers/protobuf-javascript#25 is related.protocolbuffers/protobuf#267 is related, and even after the fixes mentioned in protocolbuffers/protobuf#267, it would be still blocked against this one if
wrappers.proto
is not also recompiled incommonjs_strict
mode.A possible solution would be to replace all direct usage of that compiled js file with a proto file inside this repo, compiled in the same mode as all the other proto files. Perhaps even a subset of that file if not all imports are used.
The text was updated successfully, but these errors were encountered: