Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes application when cached data is available #21

Open
withinboredom opened this issue Feb 2, 2024 · 0 comments
Open

Crashes application when cached data is available #21

withinboredom opened this issue Feb 2, 2024 · 0 comments

Comments

@withinboredom
Copy link

During some resiliency tests to see what happens in various conditions, we noticed a couple of issues:

  1. The connection cannot be setup due to missing credentials. This will immediately throw an {{\Exception}} exception, not even trying to load from cache first
  2. There is a connection issue, etc (this will only happen if the cache is no longer valid/not used). This will throw Exceptions from a {{Psr18Client}}.

If credentials are missing/invalid but there is a valid cache, it should use the cache (for example, rolling credentials).

If connection issues and an expired cache exist, the cache should still be used until a connection can be re-established, perhaps only logging the issue. If there isn't a cache, it should only throw when trying to use a gated feature (and leave catching an exception to the developer). At least, this is what I would expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant