Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Code Quality of Existing Code #3

Open
suyashkumar opened this issue Jun 23, 2018 · 0 comments
Open

Investigate Code Quality of Existing Code #3

suyashkumar opened this issue Jun 23, 2018 · 0 comments
Labels
cleanup

Comments

@suyashkumar
Copy link
Contributor

Audit existing code quality, identify any areas necessary for refactors.
@suyashkumar suyashkumar mentioned this issue Jul 7, 2018
Merged
suyashkumar added a commit that referenced this issue Jul 9, 2018
@suyashkumar
Refactor API, add Parser Interface (#13)
9504516 
This change refactors the core `go-dicom` API to use an interface called `Parser`. This allows for more elegant dependency injection of items (like channels, previous data elements) with a clean end user api (so that the user doesn't have to worry about passing in those references themselves). Using an interface like this will also make typical testing easier on the end user, and is also more canonical golang imho. This closes #11 and addresses #3. This also puts some plumbing in place for #5.
@suyashkumar suyashkumar mentioned this issue Jul 24, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suyashkumar