Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the Dockerfiles #6

Open
dave-tucker opened this issue Dec 17, 2015 · 6 comments
Open

Include the Dockerfiles #6

dave-tucker opened this issue Dec 17, 2015 · 6 comments

Comments

@dave-tucker
Copy link
Contributor

Would make a lot of sense to include the Dockerfiles here and to set up autobuilds on the dockerhub. That way, it's easy to remember to pull gophernet/<tool>

As they are maintained here, we can also make sure they are of good quality and it's a central place where people can open issues etc..

Also, with a bit of magic #4 and #5, we can embed the Dockerfile on the page + explain a little about "how" the tool was Dockerized

@fredhsu
Copy link
Member

fredhsu commented Dec 17, 2015

Any best practice on how we should we organize/name them? A subdirectory for each tool? Or create .Dockerfile or something?

@dave-tucker
Copy link
Contributor Author

I was thinking subdirectory for each tool
Here's a great example: https://github.com/jfrazelle/dockerfiles

@fredhsu
Copy link
Member

fredhsu commented Dec 18, 2015

Ok, before I read this I went and put the dockerfiles in subdirectories.. does the current structure make sense?

@nerdalert
Copy link
Contributor

subir for each lgtm. Thanks @fredhsu @dave-tucker

netmanchris added a commit that referenced this issue Dec 31, 2015
formatting and dockerfiles for issues #3 #4 #6. LGTM
@nerdalert
Copy link
Contributor

TODO: move to the Gopher-Net docker hub account someone setup. Ty to whoever set it up.

@dave-tucker
Copy link
Contributor Author

@nerdalert that was me! We needed that for the OVS plugin.
Will get autobuilds set up for this repo shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants