Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an assignment problem solver #954

Closed
carlosgmartin opened this issue Apr 27, 2024 · 4 comments
Closed

Add an assignment problem solver #954

carlosgmartin opened this issue Apr 27, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@carlosgmartin
Copy link
Contributor Author

carlosgmartin commented Sep 19, 2024

@vroulet What would be the best place to add a solver function? optax.contrib.solve_linear_assignment_problem? I can create a draft PR with my current implementation.

@vroulet
Copy link
Collaborator

vroulet commented Sep 19, 2024

Hello @carlosgmartin,
That's a good question. The contrib folder is more for algorithms that did not pass the test of time (fancy new optimizers for deep learning typically). A linear assignment problem has passed the test of time so I think it should not be in the contrib folder. I think the best would be to follow the structure in scipy, i.e. simply making a new folder called assignment (maybe one day someone will also want to add quadratic_assignment).
The most important part here would be to have

  1. a clear documentation with doctests,
  2. a notebook example to understand how to use it and in which context.
    Given your past record of contributions, I think you'll be able to produce such a clean contribution.
    Then the main issue as pointed out by Jake in Add linear_sum_assignment jax-ml/jax#16974 is the burden of maintenance. Would you commit to help maintaining that function? (open-source means potentially forever maintenance just for you to be aware)

@carlosgmartin
Copy link
Contributor Author

The linear assignment problem is an important and standard problem in optimization, as you've noted, so I think it's worth adding to optax. To that end, I've started a PR at #1083 and welcome any feedback.

@carlosgmartin
Copy link
Contributor Author

Closed by #1083.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants