Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker executor wraps some gRPC calls with retry logic twice #1084

Closed
vigoo opened this issue Nov 25, 2024 · 1 comment
Closed

Worker executor wraps some gRPC calls with retry logic twice #1084

vigoo opened this issue Nov 25, 2024 · 1 comment

Comments

@vigoo
Copy link
Contributor

vigoo commented Nov 25, 2024

It uses GrpcClient which already does retries, and wraps it in a secondary layer of retrying unnecessarily.

@vigoo vigoo added this to the Golem 1.2 milestone Dec 6, 2024
@vigoo
Copy link
Contributor Author

vigoo commented Jan 6, 2025

This is by design, the inner retry is just recreating connections of the gRPC connection pool while the outer retry logic deals with all kind of retriable errors.
This could be unified later but it is not a bug now.

@vigoo vigoo closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant