You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current implementation depends too much on using time manipulation and because of that some tests take a long time to run (testTaskAt is one example, as it depends on the system changing minute, even though I believe we could fix this by testing it differently. Another example is the recent locking implementation).
This also causes some weird bugs that happen only at certain times (I've seen cases where time.Now().Minute() + 1 was used to compare times, causing failures if you ran the test suite anytime at HH:59
We should find a way to end this by wrapping the system clock and thus being able to mock and control it.
copy/paste from here
Current implementation depends too much on using time manipulation and because of that some tests take a long time to run (testTaskAt is one example, as it depends on the system changing minute, even though I believe we could fix this by testing it differently. Another example is the recent locking implementation).
This also causes some weird bugs that happen only at certain times (I've seen cases where
time.Now().Minute() + 1
was used to compare times, causing failures if you ran the test suite anytime atHH:59
We should find a way to end this by wrapping the system clock and thus being able to mock and control it.
Further reading
The text was updated successfully, but these errors were encountered: