Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue client doesn't always react to the changes to aggregated validationState #160

Closed
sadiqkhoja opened this issue Jul 10, 2024 · 0 comments · Fixed by #169
Closed

Vue client doesn't always react to the changes to aggregated validationState #160

sadiqkhoja opened this issue Jul 10, 2024 · 0 comments · Fixed by #169
Assignees
@eyelidlessness
Labels
engine

Comments

@sadiqkhoja
Copy link
Contributor

sadiqkhoja commented Jul 10, 2024 •
edited
Loading

ValidationState is not bubbling up for nested subtree. See this branch where I am printing validationState.voilations for Form root and groups. Validation state is being updated for parent but not for grandparent :(
@sadiqkhoja sadiqkhoja self-assigned this Jul 10, 2024
@sadiqkhoja sadiqkhoja changed the title [draft] Vue client doesn't react to the changes to array state unless watch explicitly [draft] Vue client doesn't react to the changes to array state unless watched explicitly Jul 10, 2024
@sadiqkhoja sadiqkhoja changed the title [draft] Vue client doesn't react to the changes to array state unless watched explicitly Vue client doesn't always react to the changes to aggregated validationState Jul 15, 2024
@eyelidlessness eyelidlessness mentioned this issue Jul 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Web Forms Jul 16, 2024
@sadiqkhoja sadiqkhoja mentioned this issue Jul 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyelidlessness eyelidlessness

Labels
engine
Projects
Web Forms
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: reactivity of aggregated validation violations on deep descendants getodk/web-forms
2 participants
@eyelidlessness @sadiqkhoja