Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create seamless top app bar colour #6359

Closed
alyblenkin opened this issue Aug 20, 2024 · 4 comments
Closed

Create seamless top app bar colour #6359

alyblenkin opened this issue Aug 20, 2024 · 4 comments
Milestone

Comments

@alyblenkin
Copy link
Collaborator

Part of app bar rework #6320

We want to ensure we have a seamless colour shared with the app bar and status bar so we don't get the zebra stripe at the top.

The M3 doc says the easiest way is to enable displaying content edge-to-edge: https://github.com/material-components/material-components-android/blob/master/docs/components/TopAppBar.md#status-bar-and-edge-to-edge

@alyblenkin alyblenkin converted this from a draft issue Aug 20, 2024
@alyblenkin alyblenkin added this to the v2024.3 milestone Aug 20, 2024
@alyblenkin alyblenkin changed the title Create seamless colour with the top app bars Create seamless top app bar colour Aug 20, 2024
@grzesiek2010 grzesiek2010 mentioned this issue Aug 26, 2024
6 tasks
@grzesiek2010 grzesiek2010 self-assigned this Aug 30, 2024
@grzesiek2010 grzesiek2010 moved this from ready to in progress in ODK Collect Oct 7, 2024
@seadowg
Copy link
Member

seadowg commented Oct 23, 2024

@grzesiek2010 is this still in progress or should I move it back to "ready"?

@seadowg seadowg modified the milestones: v2024.3, v2024.4 Oct 23, 2024
@grzesiek2010
Copy link
Member

I think I had one more idea to explore so it can remain in progress for now but in v2024.4 not v2024.3.

@grzesiek2010
Copy link
Member

Ok let's move it back to ready for now and opt out (using windowOptOutEdgeToEdgeEnforcement) as described in #6547

@grzesiek2010 grzesiek2010 removed their assignment Jan 13, 2025
@grzesiek2010 grzesiek2010 moved this from in progress to ready in ODK Collect Jan 13, 2025
@seadowg
Copy link
Member

seadowg commented Jan 14, 2025

I'll close this for the moment as we have no plans to switch the whole app to edge to edge for the moment. I'm imagining that we might choose to build new screens edge to edge and maybe adopt it in other places, so I think it should be a case by case conversation moving forward.

@seadowg seadowg closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
@github-project-automation github-project-automation bot moved this from ready to done in ODK Collect Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

No branches or pull requests

3 participants