Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implicitly sized decimal #13

Open
gennyble opened this issue Jun 30, 2022 · 2 comments
Open

implicitly sized decimal #13

gennyble opened this issue Jun 30, 2022 · 2 comments
Labels
question Further information is requested

Comments

@gennyble
Copy link
Owner

Currently you may do =63 and or =601 and it'll use the smallest integer that it can that's still in octets. So 63'd be a u8 and 601 a u16. In talking about hext with someone during an interview, they raised a good point: that is not what you may expect for a binary format. Should we make it so using decimal without a size is a syntax error? Set a default size, but explicitly in the header? Should it error if it overflows?

@gennyble gennyble added the question Further information is requested label Jun 30, 2022
@gennyble
Copy link
Owner Author

We could always assume them to be bytes. That seems like a fine solution? Why assume at all though? We'll sleep on it,

@gennyble
Copy link
Owner Author

gennyble commented Sep 9, 2022

bytes, they're bytes. we think this is the best solution. now to implementation!

No, I lied, I like explicitly in the header. Assume nothing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant