Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOR | Wrong strategy value, strange error #11

Closed
4TT1L4 opened this issue Oct 9, 2023 · 0 comments · Fixed by #27
Closed

SOR | Wrong strategy value, strange error #11

4TT1L4 opened this issue Oct 9, 2023 · 0 comments · Fixed by #27
Assignees
@Micrograx
Labels
Configuration A change to config files, deployments and/or dependencies. Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Small High-Level effort estimation. Category "lowest effort".

Comments

@4TT1L4
Copy link
Contributor

4TT1L4 commented Oct 9, 2023

Problem:

  • If an invalid BOTC_EXECUTION_STRAT value is set, the logged error message is not really helpful:
geniusyield-orderbot-exe: user error (Parse failure: could not parse variable "BOTC_EXECUTION_STRAT" into type [Char])

The message contains some information about which env var is not correct, but it would be nice to print the possible values instead.

Solution:

  • Improve the validation of the BOTC_EXECUTION_STRAT value and print a more helpful error message, so the users could easily fix config errors.
@4TT1L4 4TT1L4 added Configuration A change to config files, deployments and/or dependencies. Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Small High-Level effort estimation. Category "lowest effort". labels Oct 9, 2023
@4TT1L4 4TT1L4 assigned Micrograx, alegadea and 4TT1L4 and unassigned Micrograx, alegadea and 4TT1L4 Oct 11, 2023
Micrograx added a commit that referenced this issue Oct 11, 2023
@Micrograx
Feat #11: Adds error messages to env vars parsing
85c202b
Micrograx added a commit that referenced this issue Oct 11, 2023
@Micrograx
Feat #11: Adds allStrategies list
9a9c5a7
@Micrograx Micrograx linked a pull request Oct 11, 2023 that will close this issue
11 wrong strategy value strange error #27
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Micrograx Micrograx

Labels
Configuration A change to config files, deployments and/or dependencies. Priority - Low Issue has low priority and has to be worked on after blocker and high issues T-Shirt size - Small High-Level effort estimation. Category "lowest effort".
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

11 wrong strategy value strange error geniusyield/smart-order-router
3 participants
@4TT1L4 @Micrograx @alegadea