Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cron task crash #4

Closed
ccsmart opened this issue Mar 26, 2018 · 15 comments
Closed

cron task crash #4

ccsmart opened this issue Mar 26, 2018 · 15 comments
Assignees
@kohsah
Labels
bug

Comments

@ccsmart
Copy link
Contributor

ccsmart commented Mar 26, 2018

Mar 26 11:54:00 alldev node: /home/gawatidevserver/portal/filtercache.js:262
Mar 26 11:54:00 alldev node: if (filterValue[KW].length <= KW_THRESHOLD) {
Mar 26 11:54:00 alldev node: ^
Mar 26 11:54:00 alldev node: TypeError: Cannot read property 'length' of undefined
Mar 26 11:54:00 alldev node: at remapKeyWords (/home/gawatidevserver/portal/filtercache.js:262:25)
Mar 26 11:54:00 alldev node: at smartFilterByName (/home/gawatidevserver/portal/filtercache.js:250:18)
Mar 26 11:54:00 alldev node: at Array.map ()
Mar 26 11:54:00 alldev node: at processRouteSmartFilterCache (/home/gawatidevserver/portal/filtercache.js:222:38)
Mar 26 11:54:00 alldev node: at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
Mar 26 11:54:00 alldev systemd: gawatidevserver_cron.service: main process exited, code=exited, status=1/FAILURE
@kohsah
Copy link
Contributor

kohsah commented Mar 26, 2018 •
edited
Loading

@ccsmart Can you attach the full log ? Seems to happen after its run for a while .

@ccsmart
Copy link
Contributor Author

ccsmart commented Mar 26, 2018

these two lines in front can probably be attributed to the same process:
Mar 26 11:54:00 alldev node: responseFetchRecent
Mar 26 11:54:00 alldev node: success: created cache portal-cache/recent-docs.json

@ccsmart
Copy link
Contributor Author

ccsmart commented Mar 26, 2018

there is another instance before, essentially the same, but then, just noticed some smaller differences:
Mar 26 11:54:00 alldev node: /home/gawatidevserver/portal/filtercache.js:262
Mar 26 11:54:00 alldev node: if (filterValue[KW].length <= KW_THRESHOLD) {
Mar 26 11:54:00 alldev node: ^
Mar 26 11:54:00 alldev node: TypeError: Cannot read property 'length' of undefined
Mar 26 11:54:00 alldev node: at remapKeyWords (/home/gawatidevserver/portal/filtercache.js:262:25)
Mar 26 11:54:00 alldev node: at smartFilterByName (/home/gawatidevserver/portal/filtercache.js:250:18)
Mar 26 11:54:00 alldev node: at Array.map ()
Mar 26 11:54:00 alldev node: at processRouteSmartFilterCache (/home/gawatidevserver/portal/filtercache.js:222:38)
Mar 26 11:54:00 alldev node: at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
Mar 26 11:54:00 alldev systemd: gawatidevserver_cron.service: main process exited, code=exited, status=1/FAILURE

@ccsmart
Copy link
Contributor Author

ccsmart commented Mar 26, 2018

funny. i see now, the difference appears to be github cutting some things out.
please see attached original
Mar 26 11_54_00 alldev node_ _home_gawatidevserver_portal_filtercache.js_262.txt

@kohsah
Copy link
Contributor

kohsah commented Mar 26, 2018 •
edited
Loading

Fixed in 674e7e3

There was an incorrect file existence check, which was likely the culprit : 674e7e3#diff-d4d86a6f43630eea12f11f874d2e8e78L177

@kohsah kohsah self-assigned this Mar 26, 2018
@kohsah
Copy link
Contributor

kohsah commented Apr 3, 2018

@ccsmart Any recurring manifestation of this problem ?

@ccsmart
Copy link
Contributor Author

ccsmart commented Apr 3, 2018 via email

@kohsah
Copy link
Contributor

kohsah commented Apr 3, 2018

@ccsmart are those error messages ? there is also a significant amount of info logging by the service which are not errors but informational or warning messages.

@ccsmart
Copy link
Contributor Author

ccsmart commented Apr 3, 2018

Actually that one made it into the wrong isse. Above suppression messages this is for #5 . Lets wait for #5 fix as at the moment, its hard to find the needle in the haystack of #5 while also not being sure its at all recorded due to suppression due to that one.

@ccsmart
Copy link
Contributor Author

ccsmart commented Apr 9, 2018 •
edited
Loading

This one just hit again, with updated line numbers:

Apr 9 13:04:44 alldev systemd: Started Gawati API server.
Apr 9 13:04:44 alldev systemd: Starting Gawati API server...
Apr 9 13:05:00 alldev node: /home/gawatidevserver/portal/filtercache.js:248
Apr 9 13:05:00 alldev node: if (filterValue[KW].length <= KW_THRESHOLD) {
Apr 9 13:05:00 alldev node: ^
Apr 9 13:05:00 alldev node: TypeError: Cannot read property 'length' of undefined
Apr 9 13:05:00 alldev node: at remapKeyWords (/home/gawatidevserver/portal/filtercache.js:248:25)
Apr 9 13:05:00 alldev node: at smartFilterByName (/home/gawatidevserver/portal/filtercache.js:236:18)
Apr 9 13:05:00 alldev node: at Array.map ()
Apr 9 13:05:00 alldev node: at processRouteSmartFilterCache (/home/gawatidevserver/portal/filtercache.js:208:38)
Apr 9 13:05:00 alldev node: at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
Apr 9 13:05:00 alldev systemd: gawatidevserver_cron.service: main process exited, code=exited, status=1/FAILURE
Apr 9 13:05:00 alldev systemd: Unit gawatidevserver_cron.service entered failed state.
Apr 9 13:05:00 alldev systemd: gawatidevserver_cron.service failed.

@kohsah
Copy link
Contributor

kohsah commented Apr 9, 2018

@ccsmart OK ...another fix attempt in 3d1797a

@ccsmart
Copy link
Contributor Author

ccsmart commented Apr 17, 2018

Still unfortunately...

Apr 17 11:01:00 alldev node: /home/gawatidevserver/portal/filtercache.js:259
Apr 17 11:01:00 alldev node: if (filterValue[KW].length <= KW_THRESHOLD) {
Apr 17 11:01:00 alldev node: ^
Apr 17 11:01:00 alldev node: TypeError: Cannot read property 'length' of undefined
Apr 17 11:01:00 alldev node: at remapKeyWords (/home/gawatidevserver/portal/filtercache.js:259:29)
Apr 17 11:01:00 alldev node: at smartFilterByName (/home/gawatidevserver/portal/filtercache.js:248:16)
Apr 17 11:01:00 alldev node: at Array.map ()
Apr 17 11:01:00 alldev node: at processRouteSmartFilterCache (/home/gawatidevserver/portal/filtercache.js:220:40)
Apr 17 11:01:00 alldev node: at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3)
Apr 17 11:01:00 alldev node: success: created smart filter cache

@kohsah
Copy link
Contributor

kohsah commented Apr 20, 2018

@ccsmart hopefully this be0e867 should fix the problem

@kohsah
Copy link
Contributor

kohsah commented May 16, 2018

@ccsmart is this still occuring ?

@ccsmart
Copy link
Contributor Author

ccsmart commented May 16, 2018 •
edited
Loading

seems not occuring, would open new one if needed

@ccsmart ccsmart closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kohsah kohsah

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kohsah @ccsmart