docker::run init script should exit zero when already running #626
Comments
chriskuehl
added a commit
to Yelp/garethr-docker
that referenced
this issue
Jan 27, 2017
**These patches do not block upgrading to the latest garether-docker; they can both be dropped.** Both of these changes are only necessary because we are so far behind upstream, which already has very good support for systemd. The change to the exit code was proposed upstream anyway as it is an overall good patch (init scripts are supposed to exit 0 when asked to start and the service is already running): garethr#626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the script exits 7 when the container is already running, but the Linux Standard Base specification specifies that
startwhen the service is already running should be considered successful: https://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/iniscrptact.htmlWould you accept a patch to make it return zero instead of seven? The current behavior is causing us problems because the init system (systemd) tries to start the service, gets status seven, and considers it failed (and keeps trying to start it unsuccessfully forever).
The text was updated successfully, but these errors were encountered: