Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker finally removed -d so service does not start #442

Open
flypenguin opened this issue Feb 16, 2016 · 4 comments
Open

docker finally removed -d so service does not start #442

flypenguin opened this issue Feb 16, 2016 · 4 comments
Labels

Comments

@flypenguin
Copy link

In version 1.10 docker has removed the "docker -d" parameter. It was already deprecated for a while, and now the service won't start any more.

$ docker --version
Docker version 1.10.1, build 9e83765
$ docker -d
flag provided but not defined: -d
See 'docker --help'.

$ docker --version
Docker version 1.9.1, build a34a1d5
$ docker -d
Warning: '-d' is deprecated, it will be removed soon. See usage.
WARN[0000] please use 'docker daemon' instead.
INFO[0000] API listen on /var/run/docker.sock
[...]
@garethr
Copy link
Owner

garethr commented Feb 16, 2016

This should be fixed in master and in the 5.1 release of the module that went out today.

@garethr garethr closed this as completed Feb 16, 2016
@flypenguin
Copy link
Author

nope. Not with Ubuntu wily. :(

@garethr
Copy link
Owner

garethr commented Feb 16, 2016

I've not tested at all with Wily, although I'd be happy to see support there. I'll definitely have support for the Xenial LTS come later this year. This should just involve changes to the params in theory.

If you could post a gist or similar output from the whole run that would be useful, the templates should in-theory be using the override with the new param: https://github.com/garethr/garethr-docker/blob/master/templates/etc/systemd/system/docker.service.d/service-overrides-debian.conf.erb#L5

@garethr garethr added the bug label Feb 16, 2016
@flypenguin
Copy link
Author

hm. I just had a look through the repo, and I don't see why it should not work. Still, I installed v5.1.0 on my host, and I still got "-d" as daemon command.

I am right now using the override_service_template parameter to use my own template as a quick fix, maybe I'll try again at some later point. Got to get something working until tomorrow and docker is essential to this ;)

@garethr garethr reopened this Feb 17, 2016
cegeka-jenkins pushed a commit to cegeka/puppet-docker that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants