MarkdownParser problem

[AndyWu2015]

the BREAKING_CHANGES.markdown file was updated and they added "" in href for jumping to some block , but I found that our parser can't parse this feature correctly. It just generates wrong href content , can we fix that ?

[gamerson]

Yes please try to fix it, we need the MarkdownParser to work correctly.
You can send them a pull request.

On Wed, May 25, 2016 at 3:52 AM, Andy Wu [email protected] wrote:

the BREAKING_CHANGES.markdown file was updated and they added "
http://id=xxx" in href for jumping to some block , but I found that our
parser can't parse this feature correctly. It just generates wrong href
content , can we fix that ?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

[AndyWu2015]

got it

[AndyWu2015]

but I can't find the source code of com.liferay.markdown.converter in liferay-portal repo ,where should I sent the pull request to ?

[gamerson]

Its in the liferay-docs repo

On Thu, May 26, 2016 at 12:49 AM, Andy Wu [email protected] wrote:

but I can't find the source code of com.liferay.markdown.converter in
liferay-portal repo ,where should I sent the pull request to ?

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33 (comment)

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

[gamerson]

https://github.com/liferay/liferay-docs/

On Thu, May 26, 2016 at 12:53 AM, Greg Amerson [email protected]
wrote:

Its in the liferay-docs repo

On Thu, May 26, 2016 at 12:49 AM, Andy Wu [email protected]
wrote:

but I can't find the source code of com.liferay.markdown.converter in
liferay-portal repo ,where should I sent the pull request to ?

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33 (comment)

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

[AndyWu2015]

Are you sure ? I didn't find it.

[gamerson]

/dev/repos/liferay/liferay-docs(master ✔) find . | grep Markdown
./code/liferay-doc-utils/src/com/liferay/documentation/util/AddMarkdownChTemplate.java
./code/liferay-doc-utils/src/com/liferay/documentation/util/AddMarkdownMetadata.java
./code/liferay-doc-utils/src/com/liferay/documentation/util/ConcatMarkdown.java
./code/liferay-doc-utils/src/com/liferay/documentation/util/MarkdownToHtmlDebuggerMain.java
./code/liferay-doc-utils/src/com/liferay/documentation/util/MarkdownToHtmlMain.java

On Thu, May 26, 2016 at 12:58 AM, Andy Wu [email protected] wrote:

Are you sure ? I didn't find it.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33 (comment)

Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com

[AndyWu2015]

Yeah , I know these classes is just calling com.liferay.markdown.converter.MarkdownConverter and MarkdownConverterFactoryUtil , I mean I can't find them.

[AndyWu2015]

never mind , i found them in com.liferay.knowledge.base.markdown.converter in liferay-portal repo , it was renamed.