Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] "prerelease" flag isn't properly forwarded between jobs to publish to 3rd party stores #370

Open
lesquoyb opened this issue Nov 12, 2024 · 3 comments
Assignees
Labels
😱 Bug The issue reveals a bug in GAMA 👍 Fix to be tested 🧑‍🔧 Github Actions This issue concerns one repository's automated workflow

Comments

@lesquoyb
Copy link
Contributor

Is your request related to a problem? Please describe.
It seems that we forgot to update the docker alpha image in the action that publishes GAMA.

Describe the improvement you'd like
When a new alpha is built by the github action, in addition to all the publication, we should push a new docker version (alpha or latest depending on tags)

Additional context
Discovered thanks to feedbacks in #352

@lesquoyb lesquoyb added 🤗 Enhancement This is a request for enhancement 🧑‍🔧 Github Actions This issue concerns one repository's automated workflow labels Nov 12, 2024
@RoiArthurB
Copy link
Contributor

That's not really an error : while generating (pre-)release, the workflow offers to make it only for Github, or to broadcast the release everywhere. Since, recently, we're making releases only for Github, the docker workflow is never triggered 🤷

So it's just the normal way things works.

Now the real question is, do we want to have the docker alpha matching the github alpha (i.e. give the option to make pre-release only available in "our stores" (github, docker) or every stores (homebrew, ppa, windows, etc)).

@lesquoyb
Copy link
Contributor Author

lesquoyb commented Dec 2, 2024

Maybe it's just a problem of parameter names. For the last release I gave in example, I think I didn't pick "stable release" nor "publish only on github", you can check it there idk how to get the parameters I picked but you can see that it's pushed to windows store.
Now I have no idea what I should have picked to publish it also on docker, is it automatically skipped if it's not a stable ?

@RoiArthurB
Copy link
Contributor

RoiArthurB commented Dec 4, 2024

Ok I identified it, indeed it's a bug.

The condition needs.get-tag-info.outputs.prerelease == 'true' isn't checked as some step's output are not properly forwarded between steps (you can see some steps skipped too in the Windows one)... And after a fresh look at it, it's strangely built too, so I'll rework it :)

@RoiArthurB RoiArthurB added 😱 Bug The issue reveals a bug in GAMA and removed 🤗 Enhancement This is a request for enhancement labels Dec 4, 2024
@RoiArthurB RoiArthurB changed the title [GHA] docker alpha image is not updated at each new build [GHA] "prerelease" flag isn't properly forwarded between jobs to publish to 3rd party stores Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😱 Bug The issue reveals a bug in GAMA 👍 Fix to be tested 🧑‍🔧 Github Actions This issue concerns one repository's automated workflow
Projects
None yet
Development

No branches or pull requests

2 participants