Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/A11y: Audit SkipLink #9

Open
fpapado opened this issue Jan 11, 2019 · 0 comments
Open

Improvement/A11y: Audit SkipLink #9

fpapado opened this issue Jan 11, 2019 · 0 comments

Comments

@fpapado
Copy link
Contributor

fpapado commented Jan 11, 2019

I went down a rabbit hole of browser bugs and mobile testing, after reading this https://axesslab.com/skip-links/.

Turns out, Skip Links might not get announced if tabindex="-1" does not exist on the focus target (i.e. #main in this case).
On the other hand, if tabindex=-1 is present, then the focus behaviour for tapping somewhere on the page can bring focus all the way to the top. (It really is not supposed to do that).

One potential solution is to only add tabindex right before the focus is moved, and remove it after. This relies on JS, but is largely a progressive enhancement. Without JS, the behaviour is still a bit "meh", because it seems to me that the tabindex bug can be more serious; or, another way, the announcement seems to be getting fixed.

Steps:

  • Try out the solution by adding a js/SkipLink.js module
  • Test on Android and iOS, both with and without (the PR app helps!)
  • Decide on the way forward, document it
  • Reach out to folks / write and share. I think it can help others!

Might want to look into various bug trackers from browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant