more concise tests with pytest.raises

[shimwell]

We have lots of tests that have a nested function def and then assert the function call raises an error, for example

paramak/tests/tests_units/test_shape.py

Lines 64 to 76 in 8862e29

	def test_graveyard_error_when_no_offset_or_size(self):
	"""Attempts to make a shape with a graveyard_size that is an int
	which should raise a ValueError"""
	def incorrect_graveyard():
	test_shape = paramak.RotateStraightShape(
	points=[(0, 0), (0, 20), (20, 20)],
	graveyard_size=None,
	graveyard_offset=None,
	)
	test_shape.make_graveyard()
	self.assertRaises(ValueError, incorrect_graveyard)

however this test could be shortened to by using pytest.raises

def test_graveyard_error_when_no_offset_or_size(self):
    """Attempts to make a shape with a graveyard_size that is an int
    which should raise a ValueError"""

    with pytest.raises(ValueError):
        test_shape = paramak.RotateStraightShape(
            points=[(0, 0), (0, 20), (20, 20)],
            graveyard_size=None,
            graveyard_offset=None,
        )
        test_shape.make_graveyard()