Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some alpha3 values not 3 characters in length #5

Open
missinglink opened this issue Oct 2, 2014 · 2 comments
Open

some alpha3 values not 3 characters in length #5

missinglink opened this issue Oct 2, 2014 · 2 comments

Comments

@missinglink
Copy link

in some files (such as localities) the 3 digit qs_adm0_a3 property can be 2 characters in length when it should be 3 characters in length according to the spec.

ref: http://en.wikipedia.org/wiki/ISO_3166-1_alpha-3

eg:

{
  "type": "Feature",
  "properties": {
    "qs_a1_alt": null,
    "qs_a2r": null,
    "qs_level": "locality",
    "qs_gn_id": "4095233",
    "qs_iso_cc": "U",
    "qs_la_lc": "*",
    "qs_id": null,
    "qs_a1": "*Alabama",
    "qs_a0": "United States",
    "qs_a2": null,
    "qs_a2_alt": null,
    "qs_a2_lc": null,
    "qs_scale": null,
    "qs_pop": 0,
    "qs_a0_lc": null,
    "qs_a1r_lc": null,
    "qs_a2r_lc": null,
    "qs_loc_alt": "Valley Head town",
    "qs_adm0": "United States",
    "qs_adm0_a3": "US",
    "qs_source": "AUS Census",
    "qs_la": null,
    "qs_la_alt": null,
    "qs_a1_lc": "01",
    "qs_type": "G4110",
    "qs_a1r_alt": null,
    "qs_loc_lc": "0178240",
    "gs_gn_id": "4095233",
    "qs_loc": "Valley Head",
    "qs_a2r_alt": null,
    "qs_woe_id": null,
    "qs_a1r": "*"
  },
@nvkelso
Copy link
Collaborator

nvkelso commented Oct 2, 2014

Agree US > USA is the right thing to do.

But please note the adm0 codes in quatroshapes follow the Natural Earth
variant that is 99% the same as that you reference, but there are
differences.

On Thu, Oct 2, 2014 at 8:58 AM, Peter Johnson @insertcoffee <
[email protected]> wrote:

in some files (such as localities) the 3 digit qs_adm0_a3 property can be
2 characters in length when it should be 3 characters in length according
to the spec.

ref: http://en.wikipedia.org/wiki/ISO_3166-1_alpha-3

eg:

{
"type": "Feature",
"properties": {
"qs_a1_alt": null,
"qs_a2r": null,
"qs_level": "locality",
"qs_gn_id": "4095233",
"qs_iso_cc": "U",
"qs_la_lc": "_",
"qs_id": null,
"qs_a1": "_Alabama",
"qs_a0": "United States",
"qs_a2": null,
"qs_a2_alt": null,
"qs_a2_lc": null,
"qs_scale": null,
"qs_pop": 0,
"qs_a0_lc": null,
"qs_a1r_lc": null,
"qs_a2r_lc": null,
"qs_loc_alt": "Valley Head town",
"qs_adm0": "United States",
"qs_adm0_a3": "US",
"qs_source": "AUS Census",
"qs_la": null,
"qs_la_alt": null,
"qs_a1_lc": "01",
"qs_type": "G4110",
"qs_a1r_alt": null,
"qs_loc_lc": "0178240",
"gs_gn_id": "4095233",
"qs_loc": "Valley Head",
"qs_a2r_alt": null,
"qs_woe_id": null,
"qs_a1r": "*"
},


Reply to this email directly or view it on GitHub
#5.

@missinglink
Copy link
Author

thanks for the quick reply @nvkelso

I really don't mind which spec is used, the issue is that it is inconsistent across the files, in most (all?) of the other files it is USA except in localities where it is US

not a big deal; I can work around it, just a FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants