From d4bd30e065edd7861e9e54fce10be77e39c92070 Mon Sep 17 00:00:00 2001 From: Swift Kim Date: Wed, 25 Oct 2023 11:17:18 +0900 Subject: [PATCH] [sqflite] Downgrade flutter_lints to resolve analyze issues --- packages/sqflite/analysis_options.yaml | 101 ------------------ .../sqflite/example/analysis_options.yaml | 10 +- packages/sqflite/example/pubspec.yaml | 2 +- packages/sqflite/lib/sqflite_tizen.dart | 2 + packages/sqflite/pubspec.yaml | 3 - 5 files changed, 12 insertions(+), 106 deletions(-) delete mode 100644 packages/sqflite/analysis_options.yaml diff --git a/packages/sqflite/analysis_options.yaml b/packages/sqflite/analysis_options.yaml deleted file mode 100644 index 1e00f70fd..000000000 --- a/packages/sqflite/analysis_options.yaml +++ /dev/null @@ -1,101 +0,0 @@ -include: package:flutter_lints/flutter.yaml - -# Until there are meta linter rules, each desired lint must be explicitly enabled. -# See: https://github.com/dart-lang/linter/issues/288 -# -# For a list of lints, see: http://dart-lang.github.io/linter/lints/ -# See the configuration guide for more -# https://github.com/dart-lang/sdk/tree/master/pkg/analyzer#configuring-the-analyzer -# -# NOTE: Please keep this file in sync with -# https://github.com/flutter/flutter/blob/master/analysis_options.yaml - -analyzer: - language: - strict-casts: true - strict-inference: true - - errors: - # treat missing required parameters as a warning (not a hint) - missing_required_param: warning - # treat missing returns as a warning (not a hint) - missing_return: warning - # allow having TODOs in the code - todo: ignore - # Ignore errors like - # 'super_goes_last' is a deprecated lint rule and should not be used • included_file_warning - included_file_warning: ignore - -linter: - rules: - - always_declare_return_types - - avoid_dynamic_calls - - avoid_empty_else - - avoid_relative_lib_imports - - avoid_shadowing_type_parameters - - avoid_slow_async_io - - avoid_types_as_parameter_names - - await_only_futures - - camel_case_extensions - - camel_case_types - - cancel_subscriptions - - curly_braces_in_flow_control_structures - - directives_ordering - - empty_catches - - hash_and_equals - - collection_methods_unrelated_type - - no_adjacent_strings_in_list - - no_duplicate_case_values - - non_constant_identifier_names - - omit_local_variable_types - - package_api_docs - - package_prefixed_library_names - - prefer_generic_function_type_aliases - - prefer_is_empty - - prefer_is_not_empty - - prefer_iterable_whereType - - prefer_single_quotes - - prefer_typing_uninitialized_variables - - sort_child_properties_last - - test_types_in_equals - - throw_in_finally - - unawaited_futures - - unnecessary_null_aware_assignments - - unnecessary_statements - - unrelated_type_equality_checks - - unsafe_html - - valid_regexps - - - constant_identifier_names - - control_flow_in_finally - - empty_statements - - implementation_imports - - overridden_fields - - package_names - - prefer_const_constructors - - prefer_initializing_formals - - prefer_void_to_null - # - - always_require_non_null_named_parameters - - annotate_overrides - - avoid_init_to_null - - avoid_null_checks_in_equality_operators - - avoid_return_types_on_setters - - empty_constructor_bodies - - library_names - - library_prefixes - - prefer_adjacent_string_concatenation - - prefer_collection_literals - - prefer_contains - - slash_for_doc_comments - - type_init_formals - - unnecessary_const - - unnecessary_new - - unnecessary_null_in_if_null_operators - - use_rethrow_when_possible - # === doc rules === - - public_member_api_docs - # - - prefer_final_locals - - sort_constructors_first - - sort_unnamed_constructors_first diff --git a/packages/sqflite/example/analysis_options.yaml b/packages/sqflite/example/analysis_options.yaml index 2be3bca39..5b4bb8036 100644 --- a/packages/sqflite/example/analysis_options.yaml +++ b/packages/sqflite/example/analysis_options.yaml @@ -93,10 +93,18 @@ linter: - unnecessary_new - unnecessary_null_in_if_null_operators - use_rethrow_when_possible + + - dangling_library_doc_comments + - deprecated_member_use_from_same_package + - implicit_reopen + - invalid_case_patterns + - no_literal_bool_comparisons + - no_self_assignments + - no_wildcard_variable_uses + - type_literal_in_constant_pattern # === doc rules === - public_member_api_docs # # - prefer_final_locals - sort_constructors_first - sort_unnamed_constructors_first - diff --git a/packages/sqflite/example/pubspec.yaml b/packages/sqflite/example/pubspec.yaml index c9b9e47cc..8e27f923a 100644 --- a/packages/sqflite/example/pubspec.yaml +++ b/packages/sqflite/example/pubspec.yaml @@ -21,7 +21,7 @@ dependencies: dev_dependencies: pedantic: ^1.11.0 - flutter_lints: + flutter_lints: ^2.0.0 flutter_test: sdk: flutter flutter_driver: diff --git a/packages/sqflite/lib/sqflite_tizen.dart b/packages/sqflite/lib/sqflite_tizen.dart index ae494cf2a..4890440a0 100644 --- a/packages/sqflite/lib/sqflite_tizen.dart +++ b/packages/sqflite/lib/sqflite_tizen.dart @@ -2,6 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// ignore_for_file: avoid_classes_with_only_static_members + import 'package:sqflite/sqflite.dart'; /// A class to initialize the plugin. diff --git a/packages/sqflite/pubspec.yaml b/packages/sqflite/pubspec.yaml index e3c2db26d..e076fb171 100644 --- a/packages/sqflite/pubspec.yaml +++ b/packages/sqflite/pubspec.yaml @@ -20,6 +20,3 @@ dependencies: flutter: sdk: flutter sqflite: ^2.3.0 - -dev_dependencies: - flutter_lints: ^1.0.4