env cache needs to be scoped to the cluster

[adityathebe]

if two clusters have the same secretkeyRef in the same namespace, we run into the risk of returning a secret of another cluster.

duty/context/envvar.go

Lines 159 to 162 in fca8807

	id := fmt.Sprintf("secret/%s/%s/%s", namespace, name, key)
	if value, found := envCache.Get(id); found {
	return value.(string), nil
	}

[moshloop]

I don't think we support lookup of secrets from external clusters / via kubeconfig - It is always local to the current agent?

[adityathebe]

@moshloop As far as GetSecretFromCache is concerned, it uses the kubernetes client in the context which could possibly have any remote cluster's config.