Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Cast date-fields that are converted to timestamps by Netsuite Metadata/FT Connector back to dates #46

Open
2 of 4 tasks
fivetran-jamie opened this issue Mar 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fivetran-jamie
Copy link
Contributor

fivetran-jamie commented Mar 21, 2024

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

There are a few fields that are explicitly dates in Netsuite2 according to the Records Catalog. However, these get converted to timestamps in the connector due to Netsuite's metadata calling these date fields instants

Affected fields based on this code search and the Records Catalog data type:

  • transactions.trandate
  • transactions.duedate
  • transactions.closedate
  • customers.firstOrderDate
  • accountingperiods.startdate
  • accountingperiods.enddate
  • accountingperiods.closedOnDate

the following fields come up in the code search but are confirmed true datetimes (so don't change these):

  • transactions.closedOnDate
  • vendors.datecreated

For the relevant fields, we should

  1. Cast them as dates in the staging models (before doing so will we need to convert timezones?)
  2. (probably) change their aliases from *_at to *_on or *_date. This would be a breaking change though!!!!

Describe alternatives you've considered

No response

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

originated from https://getdbt.slack.com/archives/C01D1R2JLLA/p1709549154256589

@fivetran-jamie fivetran-jamie added the enhancement New feature or request label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant