Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better getBestResponse #25

Open
erhant opened this issue Dec 25, 2024 · 0 comments
Open

feat: better getBestResponse #25

erhant opened this issue Dec 25, 2024 · 0 comments
Assignees
@erhant
Labels
bug Something isn't working enhancement New feature or request

Comments

@erhant
Copy link
Member

erhant commented Dec 25, 2024

Currently, getBestResponse fails when the task is not completed, but this is really bad for UI & UX.

Instead, it should return the task status along with the best response it has at that point.

  • (PendingGeneration, firstGeneration | "")
  • (PendingValidation, firstGeneration)
  • (Completed, highestScoreGeneration)

In the currenty implementation the first two cases throw an error which need to be handled and it sucks.
@erhant erhant added bug Something isn't working enhancement New feature or request labels Dec 25, 2024
@erhant erhant self-assigned this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erhant erhant

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erhant