Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translatable + #[Reactive] RelationManager + Lazy loading #15301

Closed
john-inkesta opened this issue Jan 9, 2025 · 1 comment
Closed

Translatable + #[Reactive] RelationManager + Lazy loading #15301

john-inkesta opened this issue Jan 9, 2025 · 1 comment
Labels

Comments

@john-inkesta
Copy link
Contributor

Package

filament/spatie-laravel-translatable-plugin

Package Version

v3.2.130

Laravel Version

v11.36.1

Livewire Version

v3.5.17

PHP Version

PHP 8.3.9

Problem description

When inheriting a relation manager's active locale from the resource page, switching locale gives Typed property Filament\Resources\RelationManagers\RelationManager::$table must not be accessed before initialization.

The resource form has to be long enough to prevent the relation manager from loading right away.

Expected behavior

Not an error. The code should check if the lazy loaded relation manager was loaded.

Steps to reproduce

  • Run the reproduction repo
  • Add a survey
  • Add a question to the survey
  • Refresh the edit survey page and make sure the relation manager is not lazy loaded
  • Switch locale

Reproduction repository (issue will be closed if this is not valid)

https://github.com/town-software/filament-issue-translatable-lazy

Relevant log output

No response

@danharrin
Copy link
Member

Hello, we have handed over maintenance of this plugin to trusted developers, here: https://github.com/lara-zeus/translatable. You should open a new issue there for a resolution. It may already be fixed if you use their fork also.

The current plan is to officially deprecate the plugin and suggest the new plugin when v4 is released.

Many thanks

@danharrin danharrin closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants