Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the fedmsg consumer API message type #465

Open
jeremycline opened this issue Aug 9, 2017 · 0 comments
Open

Define the fedmsg consumer API message type #465

jeremycline opened this issue Aug 9, 2017 · 0 comments

Comments

@jeremycline
Copy link
Member

Sometimes the API uses dict objects, and sometimes it uses moksha.hub.zeromq.zeromq.ZMQMessage objects. See #462 for the issue this causes with respect to headers. We need to define what the API is and determine where it is safe to convert the ZMQMessage object to a dictionary (or otherwise include the headers).

jeremycline added a commit that referenced this issue Aug 9, 2017
This is a short-term fix for #462. We don't know what type of object is
being passed as a message.

See #465 for follow-up to
this.

Signed-off-by: Jeremy Cline <[email protected]>
jeremycline pushed a commit that referenced this issue Aug 9, 2017
This is a short-term fix for #462. We don't know what type of object is
being passed as a message.

See #465 for follow-up to
this.

This is a cherry-pick of #462

Signed-off-by: Jeremy Cline <[email protected]>
jeremycline added a commit that referenced this issue Aug 14, 2017
This is a short-term fix for #462. We don't know what type of object is
being passed as a message.

See #465 for follow-up to
this.

Signed-off-by: Jeremy Cline <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant