Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the Common Name of the x509 certificates in favor of SAN #439

Open
jeremycline opened this issue Jun 28, 2017 · 0 comments
Open

Comments

@jeremycline
Copy link
Member

Currently both implementations of the x509 crypto use the common name field to get the publisher's name. We should use the SAN field.

When moving, we need to make sure we check all the SAN values (as there can be many) when doing authorization. Patrick suggested that for compatibility, we might add the Common Name to the list of SANs for checking purposes though and issue a warning if the CN was not in any SAN values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant