Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start should accept context.Context #4

Open
yakuter opened this issue Dec 30, 2021 · 1 comment
Open

Start should accept context.Context #4

yakuter opened this issue Dec 30, 2021 · 1 comment
Assignees
@fatihkahveci

Comments

@yakuter
Copy link
Contributor

yakuter commented Dec 30, 2021

Project doesn't have context support. For graceful shutdown Start method and all functions after that should accept context from outside. If context is nil then context.Background() can be used.
@fatihkahveci
Copy link
Owner

This feature was on my to do list. I will handle this asap thanks for feedback 🍺

@fatihkahveci fatihkahveci self-assigned this Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatihkahveci fatihkahveci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fatihkahveci @yakuter