From d3f37ef1af4d22e5cc8ff1ca85ba6d27734f8dca Mon Sep 17 00:00:00 2001 From: Max Albright Date: Mon, 6 Jan 2025 17:43:41 -0800 Subject: [PATCH] Revert change to _implicitlyLogged field Summary: Don't explicitly pass a false value for_implicitlyLogged Reviewed By: ryantobinmeta Differential Revision: D67885040 fbshipit-source-id: 051dc1a573f109d6fb00717302e8d06b0f10b211 --- .../src/main/java/com/facebook/appevents/AppEvent.kt | 1 - .../src/test/kotlin/com/facebook/appevents/AppEventTest.kt | 7 ------- 2 files changed, 8 deletions(-) diff --git a/facebook-core/src/main/java/com/facebook/appevents/AppEvent.kt b/facebook-core/src/main/java/com/facebook/appevents/AppEvent.kt index 14d839707b..43d7fecb49 100644 --- a/facebook-core/src/main/java/com/facebook/appevents/AppEvent.kt +++ b/facebook-core/src/main/java/com/facebook/appevents/AppEvent.kt @@ -137,7 +137,6 @@ class AppEvent : Serializable { if (isImplicit) { eventObject.put("_implicitlyLogged", "1") } else { - eventObject.put("_implicitlyLogged", "0") log( LoggingBehavior.APP_EVENTS, "AppEvents", diff --git a/facebook-core/src/test/kotlin/com/facebook/appevents/AppEventTest.kt b/facebook-core/src/test/kotlin/com/facebook/appevents/AppEventTest.kt index f9efe23d5b..f591583a15 100644 --- a/facebook-core/src/test/kotlin/com/facebook/appevents/AppEventTest.kt +++ b/facebook-core/src/test/kotlin/com/facebook/appevents/AppEventTest.kt @@ -47,13 +47,6 @@ class AppEventTest : FacebookPowerMockTestCase() { assertThat(json?.getString("key4")).isEqualTo("value4") } - @Test - fun testIsImplicitlyLogged() { - val appEvent = AppEventTestUtilities.getTestAppEvent() - val json = appEvent.getJSONObject() - assertThat(json.getString("_implicitlyLogged")).isEqualTo("0") - } - @Test fun testAppEventSerializedChecksum() { val appEvent1 = AppEventTestUtilities.getTestAppEvent()