Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reusing forge-std's StdChains #469

Open
Tracked by #396
mds1 opened this issue Jan 16, 2025 · 2 comments
Open
Tracked by #396

Consider reusing forge-std's StdChains #469

mds1 opened this issue Jan 16, 2025 · 2 comments
Assignees

Comments

@mds1
Copy link
Contributor

mds1 commented Jan 16, 2025

Now that I think of it, we probably can reuse forge-std's StdChains to avoid having to maintain our own list of constants. And if there are chains forge-std is missing that we need, we can PR those into forge-std. Looks like forge-std doesn't have a way to just fetch chain ID from a chain alias but that's an easy helper method to upstream as well

Originally posted by @mds1 in #467 (comment)

@blmalone
Copy link
Contributor

This is being implemented by @ElliotFriedman

@ElliotFriedman
Copy link
Contributor

  1. create upstream PR in foundry with the L2 chainids and RPC URL's we need
  2. remove the chainids from the Constants file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants