Contracts are compiled twice when simulating / signing / running #423
Comments
geoknee
added a commit
that referenced
this issue
Dec 18, 2024
geoknee
added a commit
that referenced
this issue
Dec 19, 2024
geoknee
added a commit
that referenced
this issue
Jan 4, 2025
geoknee
added a commit
that referenced
this issue
Jan 6, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 13, 2025
…rchain (#418) * first pass at task sep 025 * bump task index existing task in flight for 025 * undo change to submodule * add exceptions for EOAs in SystemConfig storage * bump task sequence number * change validation script to use Seb's new framework * addAllowedStorageAccess for each system config * SystemConfigUpgrade exposes code exceptions thru getter * introduce SystemConfigUpgradeEcotoneScalars * add deprecation notice to task 020 * remove unecessary forge build commands Closes #423 * add some logging * reactivate all chains * update to superbundle * TEMP: do not try to load all contract addresses (some chains do not have them, e.g. metal) * improve err msg * fix superbundle * use dynamic storage array * validate in a smarter way for chains migrating from pre ecotone scalars * SuperchainRegistry: instead of skipping missing addresses globally, skip only if not found in the TOML file * update overview and readme * add some more logging * fill out validation.md * don't alias SystemConfigUpgradeEcotoneScalars * fix validation document unpack and verify all storage changes * add sep/027 to CI * undo changes to submodule * undo change to submodule * Revert "remove unecessary forge build commands" This reverts commit ef18399. * avoid shadowing variables * add explanatory comment and removed unused imports * avoid shadowing variabls * previous.owner codeException added conditionally * update forge-std to v1.9.5 * prefer stdToml.readAddressOr to rolling my own tryReadAddress * spellcheck * move overview contents into readme * set status as READY TO SIGN * Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/README.md Co-authored-by: Matt Solomon <[email protected]> * pull scalar checks out of base contract into SystemConfigUpgradeEcotoneScalars * make validation of migration of scalar from version 0 to 1 very explicit * add link to ecotone scalars specs * Update script/verification/SystemConfigUpgrade.s.sol * add step to validate target semver of SystemConfig * SystemConfigUpgrade.getSysCfgVars() copes with explicit contract versions * comments * SystemConfigUpgrade: pull gasPayingToken and disputeGameFactory checks into child contract * combine SystemConfigUpgrade with SystemConfigUpgradeEcotoneScalars and rename to HoloceneSystemConfigUpgrade * tidy * some more improvements * more code comments * Update script/verification/HoloceneSystemConfigUpgrade.s.sol * Update script/verification/HoloceneSystemConfigUpgrade.s.sol * typos * refactor for readability do not use << 8 to trim encoding version * consolidate interfaces into one file * Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Co-authored-by: Ethnical <[email protected]> * typos * Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/VALIDATION.md Co-authored-by: Ethnical <[email protected]> * improve formatting and links * tidy * respond to review comments * tidy up logging * add links to storage layouts * put `cast td` hints into validation doc * combine cases in if/else statement * better codeExceptions handling * reorganise chainConfig getters * Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/NestedSignFromJson.s.sol Co-authored-by: Sebastian Stammler <[email protected]> * add check for padding for scalar version 0 chains * add addCodeExceptions to VerificationBase * Update tasks/sep/027-holocene-system-config-upgrade-and-init-multi-chain/README.md Co-authored-by: Sebastian Stammler <[email protected]> * rename * update nonce --------- Co-authored-by: Matt Solomon <[email protected]> Co-authored-by: Ethnical <[email protected]> Co-authored-by: Sebastian Stammler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We don't need to run
forge buildbeforeforge run scriptin the justfile, since foundry will automatically build what it needs.The text was updated successfully, but these errors were encountered: