Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate OP Collective Revenue Transactions #1129

Open
MSilb7 opened this issue Dec 9, 2024 · 1 comment
Open

Migrate OP Collective Revenue Transactions #1129

MSilb7 opened this issue Dec 9, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@MSilb7
Copy link
Member

MSilb7 commented Dec 9, 2024

Requirement on having ETH transfers for L1 and L2s.

Existing Notebook: https://github.com/ethereum-optimism/op-analytics/blob/main/op_collective_economics/opcollective_feesplit/op_collective_revenue.ipynb

Existing Dune Query: https://dune.com/queries/3046107

Ideal set-up is we:

  1. Have a list of all OP Collective Receiver Addresses
  2. Track all transfers to and from those addresses, regardless of counterparty
  3. Build a list of all known Superchain member sender addresses, and tag transactions accordingly.
  4. Build a processes with Partnerships/Finance to ensure that we are as up to date as possible, leading up to revshare contract enshrinement (which we then integrate to)

Address lists
The known list exists in the Dune query (originally planned to do this in the GH repo lists, so you'll see some existing files, but we never used them and they fell out of date).

Data Schema
Transfers are infrequent and require audit-ability. So we should preserve all transaction & transfer level data, which we then build our aggregations on top of.

Other Considerations
Some transfers will come from a generic RaaS address, and not be clearly attributable by Superchain member. We should have some method for (later on) manually attributing / splitting a transfer by the appropriate Superchain member (i.e. RaaS A sends 1 ETH, we need to split 0.3 for Chain B's revshare, and 0.7 for Chain C's revshare.

@MSilb7 MSilb7 added the good first issue Good for newcomers label Dec 9, 2024
@MSilb7
Copy link
Member Author

MSilb7 commented Dec 9, 2024

See existing aggregation oplabs-tools-data.views.monthly_opcollective_revshare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant