Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor existing test suite and remove go dependency #129

Open
mininny opened this issue Jan 17, 2025 · 0 comments
Open

Refactor existing test suite and remove go dependency #129

mininny opened this issue Jan 17, 2025 · 0 comments

Comments

@mininny
Copy link
Collaborator

mininny commented Jan 17, 2025

Removing dependency of Go
Asterisc is built to work with kona which uses rust, but it was initially made to work with op-program on golang. As a result, the testing suite of Asterisc uses op-program for e2e testing and go binaries for simple RISCV emulation tests.

We want to minimize the implementation of the vm to include only the instructions that are used in kona. However, golang and rust uses different riscv64 instruction sets. And removing extraneous instructions from asterisc would result in existing test suites breaking (see this ci run for example)

Before removing these instructions, Asterisc should integrate with kona to perform e2e tests, and use simple rust binaries for its testing suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant