-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimization doesn't appear to run currently #24
Comments
Hi stanlejys, |
ah, ok - I was just going based on the matlab/gspbox implementation of prox_tik which uses prox when a forward operator is supplied. Of course, when the forward operator is identity the Chebyshev approximation is often faster. Where is your matlab prox_tv implementation? |
It is there: I see 3 different ways to implement the TV version
Maybe you should rebase the semi-supervised-learning branch and start from there. @mdeff what do you think? Good luck |
Yes please do base your work on the semi-supervised-learning branch. It should be merged in #19 once some cleanup is done (I don't have time for it now though). Maybe @rodrigo-pena has some thoughts on this as well. |
I've forked pygsp and started implementing the tikhonov optimization on my branch, but it appears that
optimization.prox_tv
does not work becausepyunlocbox
does not yet support the non-tight frame problem.Regardless, I think I've fixed
prox_tv
up to this error withpyunlocbox
. Once I getprox_tik
done/documented, i'll switch over topyunlocbox
and see what I can do about the non-tight frame case.The text was updated successfully, but these errors were encountered: