Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotests: Implement "single responsibility" approach for takeElementScreenshot function #6306

Open
AlexeyGirin opened this issue Jan 17, 2025 · 0 comments
Assignees
Labels
Autotests refactor Code refactoring, without changing the functionality
Milestone

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jan 17, 2025

Now takeElementScreenshot function contains wait logic that guarantee that if rendering process was started BEFORE takeElementScreenshot function call - it waits it's end (or simply waits 1.5 secs till timeout if no any rendering).

Image

This is violation of "single responsibility" approach and causes extra execution time for many tests.
Please remove that logic and correct all tests that illegally uses takeElementScreenshot function capability of rendering wait

@AlexeyGirin AlexeyGirin added Autotests refactor Code refactoring, without changing the functionality labels Jan 17, 2025
@AlexeyGirin AlexeyGirin added this to the Autotests milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autotests refactor Code refactoring, without changing the functionality
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants