Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving backup export and uploads location to /var/opt/emoncms/backup #51

Open
TrystanLea opened this issue Jan 13, 2020 · 6 comments
Open
Labels

Comments

@TrystanLea
Copy link
Member

@borpin I've started the process of implementing this.

First of all, the locations are changed in the master branch of the EmonScripts install scripts
openenergymonitor/EmonScripts@dc44ca2

Then the backup module install.sh script creates the folders in the right locations:
https://github.com/emoncms/backup/blob/master/install.sh

I've tested both import and export here and it works great.

So far this will only work for people building a new system using EmonScripts master branch and master branch of backup module, next step is to work out the update process...

@borpin
Copy link
Contributor

borpin commented Jan 13, 2020

Those lines are in the update scripts as well. I've mentioned before the disconnect between the install and update scripts. There need to be a way where the update scripts use the same config as used by the install script.

@TrystanLea
Copy link
Member Author

Yes looking at this earlier reminded me of the wish to merge the install and update scripts somehow into a single set of scripts that either install or update as needed...

@TrystanLea
Copy link
Member Author

Latest EmonScripts master now uses same config script and backup module config creation has been moved to the backup module install script. This feature is now ready to go live with the next merge to stable.

@borpin
Copy link
Contributor

borpin commented Jan 18, 2020

Will you make changes to the existing backup config files on update to move the destination?

Does the install script now create the backup config based on the install config (does that make sense)?

@TrystanLea
Copy link
Member Author

Yes the existing backup config file is overwritten.

Yes the backup/install.sh script creates the backup/config.cfg based on EmonScripts/install/config.ini if it exists. If it does not exist it asks the user to enter relevant locations via command line - in a manual process.

So all automated for EmonScripts users but a manual fall back for custom installations.

@borpin
Copy link
Contributor

borpin commented Jan 19, 2020

Yes the existing backup config file is overwritten.

Worth moving it to a backup (sic) version in case a user has modified it and warning them! 😁

@TrystanLea TrystanLea added the bug label Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants